Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not end pragma scanning at \t (horizontal tab) character #3410

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Do not end pragma scanning at \t (horizontal tab) character #3410

merged 1 commit into from
Apr 15, 2019

Conversation

sebasguts
Copy link
Member

but continue to scan until a "line break" character is encountered

@sebasguts sebasguts mentioned this pull request Apr 15, 2019
Merged
@sebasguts sebasguts added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Apr 15, 2019
fingolfin
fingolfin approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, I should have caught that, too.

Please add a test case! Otherwise looks good.

@sebasguts
Copy link
Member Author

Test case for a pragma with a tab?

@sebasguts
Copy link
Member Author

sebasguts commented Apr 15, 2019 •
edited
Loading

This one does not work yet. Please wait for an update before you merge.

@sebasguts
Do not end pragma scanning at \t (horizontal tab) character
35f99a2 
but continue to scan until a "line break" character is encountered
@sebasguts
Copy link
Member Author

Nevermind, that worked. I added a test, too.

@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #3410 into master will decrease coverage by 11.9%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #3410       +/-   ##
===========================================
- Coverage   85.21%   73.31%   -11.91%     
===========================================
  Files         698      534      -164     
  Lines      344174   265950    -78224     
===========================================
- Hits       293272   194968    -98304     
- Misses      50902    70982    +20080
Impacted Files Coverage Δ
lib/ctblauto.gi 5.98% <0%> (-83.31%) ⬇️
lib/ctbllatt.gi 4.94% <0%> (-79.62%) ⬇️
lib/algliess.gi 5.95% <0%> (-72%) ⬇️
lib/proto.gi 13.4% <0%> (-71.14%) ⬇️
lib/ctblpope.gi 8% <0%> (-69.47%) ⬇️
lib/contfrac.gi 31.42% <0%> (-67.15%) ⬇️
lib/lierep.gi 23.58% <0%> (-62.55%) ⬇️
lib/ctblperm.gi 39.26% <0%> (-60.74%) ⬇️
lib/zlattice.gi 20.97% <0%> (-60.53%) ⬇️
lib/schursym.gi 10.6% <0%> (-58.51%) ⬇️
... and 399 more

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.209% when pulling 35f99a2 on sebasguts:sg/pragma_fixup into 65993f6 on gap-system:master.

@olexandr-konovalov olexandr-konovalov merged commit eca0b7d into gap-system:master Apr 15, 2019
@olexandr-konovalov olexandr-konovalov mentioned this pull request Apr 15, 2019
Closed
@fingolfin fingolfin added the regression A bug that only occurs in the branch, not in a release label Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
regression A bug that only occurs in the branch, not in a release release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebasguts @coveralls @fingolfin @olexandr-konovalov